Dragon tags & mechs by heypr · Pull Request #2620 · DenizenScript/Denizen

heypr · 2024-05-08T22:25:12Z

Requested by Josh65.
Adds 3 paper-only, 1.20+ tags:
- gateway_count
- healing_crystals
- respawn_crystals
Adds 1 paper-only, 1.20+ mechanism:
- spawn_gateway
Adds 1 regular tag:
- first_dragon_killed
Adds 4 regular mechanisms;
- respawn_dragon
- reset_crystals
- respawn_phase
- first_dragon_killed

I opened this as a draft PR because I haven't tested any of this/just wrote this up, and want it open so that I don't lose it in my sea of local and published branches. Feel free to comment/review though!

mcmonkey4eva · 2024-06-26T13:59:29Z

+                if (!mechanism.hasValue()) {
+                    battle.spawnNewGateway();
+                }
+                if (mechanism.requireObject(LocationTag.class)) {


mcmonkey4eva · 2024-06-26T14:00:45Z

+        // -->
+        tagProcessor.registerMechanism("respawn_dragon", false, (object, mechanism) -> {
+            if (object.getWorld() == null) {
+                mechanism.echoError("World '" + object.world_name + "' is unloaded, cannot set respawn phase.");


... when is this a real concern?

mcmonkey4eva · 2024-06-26T14:01:23Z

+        // <--[mechanism]
+        // @object WorldTag
+        // @name respawn_phase
+        // @input ElementTag(String)


just ElementTag

tal5 · 2024-08-31T13:01:19Z

+            // @returns ElementTag(Number)
+            // @description
+            // Returns the number of end gateway portals.
+            // Only works in end worlds.


Minor nitpick, but in sounds more like the player being in an end world while the script is running or something - maybe on, for, if the world is an end world, etc.?

tal5 · 2024-08-31T13:04:52Z

+            // @attribute <WorldTag.healing_crystals>
+            // @returns ListTag(EntityTag)
+            // @description
+            // Returns a ListTag of the healing crystals located on top of the obsidian towers.


I'd mention ender/end crystals as a search aid or in the description somewhere, healing crystals is technically right but most people probably won't know them by that name.

tal5 · 2024-08-31T13:05:33Z

+            });
+
+            // <--[tag]
+            // @attribute <WorldTag.healing_crystals>


Wrong tag name

tal5 · 2024-08-31T13:12:50Z

+            // @Plugin Paper
+            // @group paper
+            // @description
+            // If no location is specified, tries to spawn a new end gateway using default game mechanics. Otherwise, spawns a new end gateway portal at the specified location.


Nitpick, but meta is usually the other way around (spawns gateway at specified location, specify no input to spawn vanilla one)

tal5 · 2024-08-31T13:13:23Z

+                    battle.spawnNewGateway();
+                }
+                else if (mechanism.requireObject(LocationTag.class)) {
+                    battle.spawnNewGateway(mechanism.getValue().asType(LocationTag.class, mechanism.context));


There should be a #valueAsType iirc?

tal5 · 2024-08-31T13:19:13Z

+        // @name respawn_phase
+        // @input ElementTag
+        // @description
+        // Set the current respawn phase of the ender dragon. Valid phases can be found at <@link url https://jd.papermc.io/paper/1.20/org/bukkit/boss/DragonBattle.RespawnPhase.html>


Link doesn't seem to work?

tal5 · 2024-08-31T13:20:28Z

+        tagProcessor.registerMechanism("respawn_phase", false, ElementTag.class, (object, mechanism, input) -> {
+            DragonBattle battle = object.getWorld().getEnderDragonBattle();
+            if (battle == null) {
+                mechanism.echoError("Provided world is not an end world!");
+                return;
+            }
+            battle.setRespawnPhase(input.asEnum(DragonBattle.RespawnPhase.class));
+        });


Needs Mechanism#requireEnum

tal5 · 2024-08-31T13:20:56Z

+
+            // <--[mechanism]
+            // @object WorldTag
+            // @name respawn_phase


tal5 · 2024-08-31T13:21:29Z

+            tagProcessor.registerMechanism("first_dragon_killed", false, ElementTag.class, (object, mechanism, input) -> {
+                DragonBattle battle = object.getWorld().getEnderDragonBattle();
+                if (battle == null) {
+                    mechanism.echoError("Provided world is not an end world!");
+                    return;
+                }
+                battle.setPreviouslyKilled(input.asBoolean());
+            });


Needs Mechanism#requireBoolean

tal5 · 2024-08-31T13:23:43Z

+            // Set whether the first ender dragon was killed already.
+            // Only works in end worlds.


Might be nice to document exactly what this does - does it reset the end and respawn the dragon? is it just a value that doesn't really affect anything?

tal5 · 2024-10-14T19:31:07Z

+            // <--[tag]
+            // @attribute <WorldTag.healing_crystals>
+            // @returns ListTag(EntityTag)
+            // @description
+            // Returns a ListTag of the healing end crystals located on top of the obsidian towers.
+            // Only works if the world is an end world.
+            // -->


These tags are missing the Paper plugin requirement/group meta

tal5 · 2024-10-14T19:32:05Z

+            // @attribute <WorldTag.respawn_crystals>
+            // @returns ListTag(EntityTag)
+            // @description
+            // Returns a ListTag of the respawn crystals located at the end exit portal.


Nitpick, but I'd probably mention end crystals here (like in the WorldTag.healing_crystals meta)

tal5 · 2024-10-14T19:37:33Z

+            // <--[mechanism]
+            // @object WorldTag
+            // @name first_dragon_killed
+            // @input ElementTag(Boolean)
+            // @description
+            // Set whether the first ender dragon was killed already.
+            // Toggling this value won't really affect anything in the end world, but may be useful when creating custom end worlds.
+            // Only works if the world is an end world.
+            // -->


Should have a tag link to first_dragon_killed (and vice versa)

heypr added 5 commits May 8, 2024 18:16

Dragon tags & mechs

1de7488

Spacing

cb733f3

Error changes

3520fa5

Merge remote-tracking branch 'upstream/dev' into dragons-rahhhhh

5f1b351

ListTag converter, add space before mech meta entry

a6691b6

heypr marked this pull request as ready for review June 26, 2024 13:36

mcmonkey4eva reviewed Jun 26, 2024

View reviewed changes

Comment thread paper/src/main/java/com/denizenscript/denizen/paper/properties/PaperWorldExtensions.java

mcmonkey4eva reviewed Jun 26, 2024

View reviewed changes

Comment thread paper/src/main/java/com/denizenscript/denizen/paper/properties/PaperWorldExtensions.java

mcmonkey4eva reviewed Jun 26, 2024

View reviewed changes

Minor fixes.

09bf2b3

mcmonkey4eva reviewed Jun 26, 2024

View reviewed changes

Comment thread plugin/src/main/java/com/denizenscript/denizen/objects/WorldTag.java

Remove unneeded null checks, added echo error if non-end world

62a9c7b

mcmonkey4eva previously approved these changes Jul 5, 2024

View reviewed changes

tal5 reviewed Aug 31, 2024

View reviewed changes

heypr added 2 commits September 17, 2024 11:44

Merge remote-tracking branch 'upstream/dev' into dragons-rahhhhh

1353da1

Meta updates.

ac3169b

heypr dismissed mcmonkey4eva’s stale review via ac3169b September 30, 2024 22:30

Updated meta, resolved all other comments

dac18a9

mcmonkey4eva previously approved these changes Oct 6, 2024

View reviewed changes

tal5 reviewed Oct 14, 2024

View reviewed changes

Meta updates

432fb02

heypr dismissed mcmonkey4eva’s stale review via 432fb02 October 15, 2024 14:19

mcmonkey4eva approved these changes Oct 16, 2024

View reviewed changes

tal5 approved these changes Oct 17, 2024

View reviewed changes

tal5 merged commit 6919884 into DenizenScript:dev Oct 17, 2024

heypr deleted the dragons-rahhhhh branch July 26, 2026 23:53

		// Set whether the first ender dragon was killed already.
		// Only works in end worlds.

Conversation

heypr commented May 8, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants